Update chokidar #464
Merged
Update chokidar #464
+87
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kainino0x
reviewed
Oct 16, 2024
chokidar v3 is no longer supported. v4 requires node 20 so 1. Added a check for v20+ 2. Make script exit if any spawn gets an error. This required watching for processes to exit and killing the other processes. 3. Update to use glob as chokidar v4 no longer does it Also fixed a minor warning in sample/utis.ts
greggman
force-pushed
the
update-chokidar
branch
2 times, most recently
from
eeb2bd8 to
188c005
Compare
kainino0x
approved these changes
Oct 18, 2024
build/tools/serve.js
Outdated
| console.log(cmd, 'exited with code:', code); | ||
| spawns.forEach((s) => s.kill()); | ||
| process.exit(code); | ||
| spawns.splice(spawns.indexOf(s), 1); |
There was a problem hiding this comment.
nit: maybe spawns could be a Set? but not important
greggman
force-pushed
the
update-chokidar
branch
from
188c005 to
446bb4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is dependent on #463
Update chokidar to v4
chokidar v3 is no longer supported. v4 requires node 20 so
Added a check for v20+
Make script exit if any spawn gets an error.
This required watching for processes to exit and
killing the other processes.
Update to use glob as chokidar v4 no longer does it
Also fixed a minor warning in sample/utis.ts